Update IExtraMetadataWriter.setExtraMetadata(...) to accept an Object#4243
Open
melissalinkert wants to merge 1 commit intoome:developfrom
Open
Update IExtraMetadataWriter.setExtraMetadata(...) to accept an Object#4243melissalinkert wants to merge 1 commit intoome:developfrom
melissalinkert wants to merge 1 commit intoome:developfrom
Conversation
If an ITagProvider is passed to this method when called on DicomWriter, the ITagProvider is directly added to the tag provider list. If a String is passed instead, then it is assumed to be a path to a file that can be parsed by DicomJSONProvider (as before). See ome#4169.
|
It looks good @melissalinkert ! It will allow me to create my own ITagProvider(s). Specifically, one that takes an Apache Jena Model as a constructor parameter. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an ITagProvider is passed to this method when called on DicomWriter, the ITagProvider is directly added to the tag provider list. If a String is passed instead, then it is assumed to be a path to a file that can be parsed by DicomJSONProvider (as before).
Drafting for consideration in 8.0.0. @ebremer, is this sufficient to cover what you had in mind for #4169? If not, concrete suggestions and/or a more complete description of the use case that needs to be considered would be very helpful.
Any writers that implement
IExtraMetadataWriterin the future then have flexibility in what they accept insetExtraMetadata(...). I don't know if this ends up being too flexible though.I did test briefly with this and still got the expected output file contents: